Skip to content
This repository has been archived by the owner on Jan 27, 2022. It is now read-only.

Fixes #432 #433

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixes #432 #433

wants to merge 4 commits into from

Conversation

Kethku
Copy link

@Kethku Kethku commented Jun 27, 2021

Fixes #432 by modifying the floating window utility functions to use relative "win" rather than relative "editor". This is because in multigrid environments the position of the documentation window was incorrect as explained in the issue.

@Kethku
Copy link
Author

Kethku commented Jun 27, 2021

Actually looks like this breaks non multigrid environments... I'll have to think a bit

@Kethku
Copy link
Author

Kethku commented Jun 27, 2021

I'm not sure what the right solution is. Looks like pum_getpos returns relative positions when multigrid. I could special case whether editor or win is used for the relative property depending on if a gui is connected, but that feels like a hack.

Any guidance would be appreciated

@hrsh7th
Copy link
Owner

hrsh7th commented Jul 2, 2021

The big change that relates to the documentation window had merged. Could you check the problem with latest compe?

@Kethku
Copy link
Author

Kethku commented Aug 12, 2021

Finally got around to testing this. Unfortunately its still broken. In a multigrid environment, the documentation window is positioned relative to the top window not the current window
image

@Kethku
Copy link
Author

Kethku commented Aug 12, 2021

Changing the relative option in the window creation to win fixes this issue for multigrid environments, but I believe breaks it for normal ones. I'm not sure what the correct way to solves this is for both use cases.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation Window Positioned incorrectly with multigrid extension
3 participants