fix: the height of docs view get wrong when content lines get wrapped #2032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the wrap_at option not pass to vim.lsp.util._make_floating_popup_size(), it calculates height with unwrapped lines. Actually the nvim-cmp shows content with wrapped lines in docs view. So when the content has very long text, the calculated height is smaller than actually required in docs view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
wrap_atoption not pass tovim.lsp.util._make_floating_popup_size(), it calculates height with unwrapped lines.Actually the nvim-cmp shows content with wrapped lines in docs view.
So when the content has very long text, the calculated height is smaller than actually required in docs view.
Before:
After fixed: