fix: Type check for snippet description #1832 #1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forsigg
changed the title
2 tasks
|
IMO, the item.detail as table is not compliant fir LSP spec. So I tgink it should be fixed in source side. |
|
I also just hit this and the commit in this PR works as a work-around. @hrsh7th What is the "source side" in this scenario? Should this bug be reported against another project? If so, which one? |
If it is source side problem, the source should check the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add type check for
item.detailthat contains description, In that case while navigating in menu for select snippetitem.detailcontains table, but expected string#1832