-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add info
command line subcommand
#1330
Conversation
Adding an info command allows the documentation to refer to it when mentioning platform specific information. This gives users a nicer experience since they don't need to think about how `ncspot` will behave on their system, but can run `ncspot info` to get that information.
Describe your changes
Issue ticket number and linkChecklist before requesting a review
|
I don't know how PRs are merged but I just now thought that maybe the PR message was used as commit message. That's why I moved the template stuff in its own comment, as that's not part of the commit message probably... I'm not sure how commit messages are created from a PR though (I know it's a setting per repo). |
Windows doesn't use the runtime path so it shouldn't be printed there.
c0e2d43
to
62f879c
Compare
With that I think it should be finished. It's rather simple, but I wanted to keep the output easy to parse if anyone wants/needs that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me! And sorry for the delay, don't have a lot of time at the moment.
No problem. If you ever need help with managing issues or PRs (like reviewing PRs or sorting/organizing issues) I could always try to help. |
Thanks again, let's get it in! :) |
Adding an info command allows the documentation to refer to it when mentioning platform specific information. This gives users a nicer experience since they don't need to think about how
ncspot
will behave on their system, but can runncspot info
to get that information.closes #1325