Handle SIGHUP signals
#1310
Closed
Handle SIGHUP signals
#1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this probably reintroduces the crashes it should handle `SIGHUP` again which currently leads into the `unreachable!()` branch. Fixes #1309
|
This will not fix the issue. I've been looking for the issue and one of the first things I did was to add Reverting won't fix the actual problem, it will just make it so |
This was referenced Oct 11, 2023
Open
dricottone
added a commit
to dricottone/ncspot
that referenced
this pull request
Jan 10, 2024
Commit a067ab2: feat: move to async POSIX signal handler Instead of trying to handle signals for every step of the `cursive` event loop, move the signal handling into its own asynchronous task and send callbacks to `cursive` when a signal arrives. PR 1305: fix: restore SIGHUP in signal handler Restore the SIGHUP signal handler which was accidentally removed in a067ab2. The commit had to be reverted and the PR was closed. Commit a1a9863: Revert "feat: move to async POSIX signal handler" ThomasFrans commented: From what I can see, it's an issue introduced by the crossterm backend. The ncurses one doesn't keep the process running. Currently I suspect Cursive is doing a write to /dev/tty which is closed, and that write blocks on the crossterm backend and returns immediately on the ncurses backend. I guess it could be resolved by switching the default backend (again)? This would solve hrkfdn#1309 and hrkfdn#1310 and hrkfdn#1282. I'd love to hear thoughts on this idea. If it's an OK solution, I'd try to see whether I can open an issue at Cursive or Crossterm to resolve the issue there, and meanwhile switch backend and add the SIGHUP handler back to finally close all these issues A commit to deprecate the crossterm/pancurses/termion backends will follow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this probably reintroduces the crashes it should handle
SIGHUPagain which currently leads into theunreachable!()branch.Fixes #1309