Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sqlite #1

Closed
mpadge opened this issue Mar 20, 2018 · 2 comments
Closed

add sqlite #1

mpadge opened this issue Mar 20, 2018 · 2 comments

Comments

@mpadge
Copy link

mpadge commented Mar 20, 2018

hey @hrbrmstr this package is a rockin 🎸 awesome idea! I'd send a PR but too lazy right now, so issue instead. I'm sure you've already thought of this obvious extension, but this would be supremely useful for internally bundled packages:

my_mongo <- 3.6.x
testthat::expect_identical(my_mongo, vershist::mongodb_latest())

And if you include sqlite3, then I'd use it straight away for vendor version bundled in bikedata. (And here too.) I'll PR that if I find me some 🕦

@hrbrmstr
Copy link
Owner

I'll bump it to the top of the list today :-)

The impetus for the pkg came from a recurring need for me to look at version distributions from scan banner grabs and to also make things like this:

image

We're doing quite a bit more of this and if I don't put things in a pkg they tend to get lost in the "useful-r-things" folder :-)

hrbrmstr added a commit that referenced this issue Mar 21, 2018
@hrbrmstr
Copy link
Owner

SQLite's in there now.

Lemme noodle on how I can optimize a "latest" function for these things. For bits like MySQL it's an expensive call but I'm also not sure how many folks want to rely on internet connectivity (i.e. if I did a daily regen of a file and sync'd it to GH so an online check could be made).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants