perf(strictyaml): refactor _normalize_linecol for better perf

Fixes iterative#10109 Signed-off-by: hqdncw <[email protected]>
hqdncw · Dec 26, 2023 · 65a3e0e · 65a3e0e
1 parent 7e3c0de
commit 65a3e0e
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/dvc/utils/strictyaml.py b/dvc/utils/strictyaml.py
@@ -161,9 +161,11 @@ def _normalize_linecol(lc: "LineCol | Tuple[Any, Any]") -> Tuple[int, int]:
     elif isinstance(lc, tuple):
         line = int(lc[0])
         col = int(lc[1])
+    else:
+        raise TypeError(f"Expected LineCol or tuple, got {lc!r}")
 
-    if not (isinstance(line, int) and isinstance(col, int)):
-        raise TypeError(f"Unable to determine neither line nor col ({line}:{col})")
+    assert isinstance(line, int)
+    assert isinstance(col, int)
 
     return line + 1, col + 1