Make HPy compatible with Python 3.11 #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antocuni
approved these changes
Nov 24, 2022
| PyMem_Free(ht->_ht_tpname); | ||
| ht->_ht_tpname = (char *) extra; | ||
| ht->ht_type.tp_name = (const char *)extra->name; | ||
| #endif |
There was a problem hiding this comment.
wow, this is brilliant.
It's also a bit scary, because if someone by chance tries to access _ht_tpname you will get nonsense. But it seems that nobody is accessing it anyway, so I suppose it's fine 👍
There was a problem hiding this comment.
I agree. I checked the CPython code and it's really just used for freeing.
As I mentioned, we could maybe use a metaclass for HPy types to store the extra info. I'll investigate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #288 .
Antonio's Hybrid-ABI PR #371, which is now merged, already solved the first problems we had with Python 3.11. However, that was not enough.
In particular, there was a subtle change in Python's
PyType_FromSpec....They do now copy the name from the type spec into a fresh buffer such that the type object owns that buffer and can free it (see https://github.com/python/cpython/blob/b5b3904f05e77f044f158307bc6bdd2bc1b670a2/Objects/typeobject.c#L3723).However, we use
tp_nameto attach ourHPyType_Extrastruct.In future, we might consider to use meta classes to avoid this hack.
I've now also added Python 3.11 to the CI (for main tests and PoC).