qthread-module #13
Open
qthread-module #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a framework to support different types of threading models including user space thread packages such as Qthreads and argobot: https://github.com/pmodels/argobots https://github.com/Qthreads/qthreads The default threading model is pthreads. Alternate thread models are specificed at configure time using the --with-threads=X option. The framework is static. The theading model to use is selected at Open MPI configure/build time. Signed-off-by: Noah Evans <[email protected]>
use the OPAL_CONFIG_POSIX_THREADS macro Signed-off-by: Howard Pritchard <[email protected]>
Signed-off-by: Noah Evans <[email protected]>
Signed-off-by: Shintaro Iwasaki <[email protected]>
remove workaround introduced into the wrappers Makefile. This can be done due to the configury refactor. rework the threads framework configury to move a good chunk of setup to the top config directory to make sure thread package specific compile/link args are defined early in the configure process. Signed-off-by: Howard Pritchard <[email protected]>
config: fix thread configury - Add double quotations - Change Argobot to Argobots config: implement Argobots check If the poll time is too long, MPI hangs. This quick fix just sets it to 0, but it is not good for the Pthreads version. Need to find a good way to abstract it. Note that even 1 (= 1 millisecond) causes disastrous performance degradation. Signed-off-by: Shintaro Iwasaki <[email protected]>
Signed-off-by: Howard Pritchard <[email protected]>
Signed-off-by: Howard Pritchard <[email protected]>
We can't make changes to external packages that we happen to embed in Open MPI. If changes need to be made to the external package, they should be made in that package itself. Signed-off-by: Howard Pritchard <[email protected]>
include files Signed-off-by: Howard Pritchard <[email protected]>
out of top level config folder and in to relevant m4 files in the threads framework Signed-off-by: Howard Pritchard <[email protected]>
Signed-off-by: Howard Pritchard <[email protected]>
Signed-off-by: Howard Pritchard <[email protected]>
Signed-off-by: Howard Pritchard <[email protected]>
Signed-off-by: Shintaro Iwasaki <[email protected]>
…2-cleanup /opal/mca/threads: clean up 3
It now works more like the ompi/mca/rte configury, modulo some edge items that are special for threading package linking, etc. Signed-off-by: Howard Pritchard <[email protected]>
hppritcha
force-pushed
the
topic/thread_framework2
branch
from
6fe3237
to
4657a82
Compare
hppritcha
force-pushed
the
topic/thread_framework2
branch
2 times, most recently
from
6308978
to
3518474
Compare
hppritcha
force-pushed
the
topic/thread_framework2
branch
2 times, most recently
from
a1f4763
to
667c1e6
Compare
jsquyres
force-pushed
the
topic/thread_framework2
branch
from
667c1e6
to
3eaef01
Compare
hppritcha
force-pushed
the
topic/thread_framework2
branch
from
3eaef01
to
205ee16
Compare
hppritcha
force-pushed
the
topic/thread_framework2
branch
from
3dcdcaf
to
d7fba60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first draft of the qthreads module