-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic management of variants in one place + Result view #123
Conversation
…or it to stay consistent with original
Pull Request Test Coverage Report for Build 6482065396
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Features look great! Some minor structural things :)
@@ -371,7 +377,7 @@ SBTabView >> removeCurrentTab [ | |||
{ #category : #tabs } | |||
SBTabView >> setActive: aNamedBlock [ | |||
|
|||
self sandblockEditor do: | |||
SBEditor current do: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was this change necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(also in the other places)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when creating the exploriants block, the block is first created and then added to the editor. should it be the other way around?
@@ -3,7 +3,8 @@ Class { | |||
#superclass : #SBStSubstitution, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noticed late but maybe we want to move this one to -Babylonian as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's in the same category as toggledcode - and even though toggledcode might become obsolete in the future, the thought of different code paths does not relate to live programming at first glance imo
@@ -0,0 +1,122 @@ | |||
Class { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably best at home in -Babylonian, too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
Adds an
Exploriants
Block, which has two tabs:Exploriants
will recompile the methods.This is currently a pragmatic solution and MVP without deeper integration testing or UI quality.
Features which were added:
SBVariantProxy
takes inspiration fromSBLinkedCopy
for copying variants and keeping consistent state between the two objects. A new class was introduced asSBLinkedCopy
assumed the original was an artefact itself. For variants, a few extra methods must be called tooSBExampleWatch
saves values for each example which reported values. When inactive, it will keep these results displayed and will not update itself in the future. When updating the modified expression, it will apply this on itself on anartefactChanged
SBExploriants
as a tab view of things which users might find interestingSBExploriantsView
is a tab inExploriants
and currently consists of the variants and resultsSBPermutation
is a helper class to manage a permutation of alternative selections