Mpi4py condition #217
Mpi4py condition #217
Conversation
|
One or more tests FAILed. See https://jenkins1.ugent.be/job/vsc-base-prbuilder/4/console for more details. |
stdweird
force-pushed
the
mpi4py_condition
branch
from
a7185c6
to
b967cdd
Compare
|
One or more tests FAILed. See https://jenkins1.ugent.be/job/vsc-base-prbuilder/5/console for more details. |
|
One or more tests FAILed. See https://jenkins1.ugent.be/job/vsc-base-prbuilder/6/console for more details. |
|
One or more tests FAILed. See https://jenkins1.ugent.be/job/vsc-base-prbuilder/7/console for more details. |
|
@JensTimmerman clueless about the errors. i can reproduce the fancylogger one, but no clue where the generaloption one comes from (nor what it means; probably a reraise of a previous exception) |
| @@ -75,6 +75,8 @@ class FancyLoggerTest(TestCase): | |||
| fd = None | |||
|
|
|||
| def setUp(self): | |||
| super(FancyLoggerTest, self).setUp() | |||
There was a problem hiding this comment.
why move this up? are you sure this has the correct side effects?
There was a problem hiding this comment.
in the sense that it doesn't matter, it has the correct side effects. i'm still ruling out any possible causes.
|
do we still need these python 2.4 workarounds, like |
|
aiui, no we don't need the 2.4 workarounds. |
|
One or more tests FAILed. See https://jenkins1.ugent.be/job/vsc-base-prbuilder/8/console for more details. |
stdweird
force-pushed
the
mpi4py_condition
branch
from
00a8811
to
5c7be98
Compare
|
One or more tests FAILed. See https://jenkins1.ugent.be/job/vsc-base-prbuilder/9/console for more details. |
| @@ -43,7 +43,7 @@ | |||
| from optparse import OptionParser, OptionGroup, Option, Values, HelpFormatter | |||
| from optparse import BadOptionError, SUPPRESS_USAGE, NO_DEFAULT, OptionValueError | |||
| from optparse import SUPPRESS_HELP as nohelp # supported in optparse of python v2.4 | |||
| from optparse import _ as _gettext # this is gettext normally | |||
| from optparse import gettext as _gettext # this is gettext.gettext normally | |||
There was a problem hiding this comment.
Why not pull this from gettext.gettext and alias it as _ as suggested in the docs.
There was a problem hiding this comment.
because it have no clue what the added value is and only confuses things
|
One or more tests FAILed. See https://jenkins1.ugent.be/job/vsc-base-prbuilder/15/console for more details. |
|
test this please |
|
One or more tests FAILed. See https://jenkins1.ugent.be/job/vsc-base-prbuilder/16/console for more details. |
|
test this please |
|
All tests PASSed. See https://jenkins1.ugent.be/job/vsc-base-prbuilder/19/console for more details. |
|
All tests PASSed. See https://jenkins1.ugent.be/job/vsc-base-prbuilder/20/console for more details. |
| if self is None: | ||
| raise Exception(msg) | ||
| else: | ||
| self.log.raiseException(msg) |
There was a problem hiding this comment.
Make this exception a consistent type with whatever's chosen above (TypeError, I guess). So except TypeError works.
…orting mpi4py altogether in case of broken mpi4py
|
All tests PASSed. See https://jenkins1.ugent.be/job/vsc-base-prbuilder/21/console for more details. |
|
All tests PASSed. See https://jenkins1.ugent.be/job/vsc-base-prbuilder/22/console for more details. |
|
@stdweird: so, EB should define |
Fixes #216 by introducing
FANCYLOGGER_IGNORE_MPI4PYenviroment variable