Skip to content

Commit

Permalink
feat: remove Column string format rounding
Browse files Browse the repository at this point in the history
Signed-off-by: Jaman Brundage <[email protected]>
  • Loading branch information
jbrundage committed Oct 7, 2022
1 parent 9b4244e commit 7876e56
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion packages/chart/src/Column.ts
Original file line number Diff line number Diff line change
Expand Up @@ -586,7 +586,7 @@ Column.prototype.publish("paletteID", "default", "set", "Color palette for this
Column.prototype.publish("useClonedPalette", false, "boolean", "Enable or disable using a cloned palette", null, { tags: ["Intermediate", "Shared"] });
Column.prototype.publish("showValue", false, "boolean", "Show Value in column");
Column.prototype.publish("showInnerText", false, "boolean", "Show Label in column");
Column.prototype.publish("showValueFormat", ".2s", "string", "D3 Format for Value", null, { disable: (w: Column) => !w.showValue() || !!w.showValueAsPercent() });
Column.prototype.publish("showValueFormat", ",", "string", "D3 Format for Value", null, { disable: (w: Column) => !w.showValue() || !!w.showValueAsPercent() });
Column.prototype.publish("showValueAsPercent", null, "set", "If showValue is true, optionally show value as a percentage by Series or Domain", [null, "series", "domain"], { disable: w => !w.showValue(), optional: true });
Column.prototype.publish("showValueAsPercentFormat", ".0%", "string", "D3 Format for %", null, { disable: (w: Column) => !w.showValue() || !w.showValueAsPercent() });
Column.prototype.publish("valueCentered", false, "boolean", "Show Value in center of column");
Expand Down
2 changes: 1 addition & 1 deletion packages/chart/src/StatChart.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export class StatChart extends HTMLWidget {
.pointSize(0)
.xAxisType("linear")
.xAxisOverlapMode("none")
.xAxisTickFormat(".2s")
.xAxisTickFormat(",")
.yAxisHidden(true)
.yAxisDomainLow(0)
.yAxisDomainHigh(110)
Expand Down
2 changes: 1 addition & 1 deletion packages/map/src/leaflet/ClusterCircles.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,5 +84,5 @@ ClusterCircles.prototype.publish("useClonedPalette", false, "boolean", "Enable o
ClusterCircles.prototype.publish("latitudeColumn", null, "set", "Latitude column", function () { return this.columns(); }, { optional: true });
ClusterCircles.prototype.publish("longitudeColumn", null, "set", "Longitude column", function () { return this.columns(); }, { optional: true });
ClusterCircles.prototype.publish("weightColumn", null, "set", "Weight column", function () { return this.columns(); }, { optional: true });
ClusterCircles.prototype.publish("weightFormat", ".2s", "string", "Number format for weight");
ClusterCircles.prototype.publish("weightFormat", ",", "string", "Number format for weight");
ClusterCircles.prototype.publish("opacity", 0.66, "number", "Opacity", null, { tags: ["Advanced"] });

0 comments on commit 7876e56

Please sign in to comment.