Add multiExt option #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yocontra
requested changes
May 15, 2018
index.js
Outdated
| var dirname = Path.dirname(path); | ||
| var basename = Path.basename(path, extname); | ||
| if (options.multiExt) { | ||
| while (Path.extname(basename) !== '') { |
There was a problem hiding this comment.
Could you avoid using a while loop here, and check if there any node built-ins that handle this? I would be curious to see how other people implement this.
There was a problem hiding this comment.
No node built-ins unfortunately. path.extname doesn't handle multiple extensions, that's why I used it in a loop at first.
Closes #16.
|
@contra |
|
Published as 1.3.0 - thanks! |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows parsing a path with multiple extensions.
Closes #16.