Clone the original file prior to renaming #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the file object is being mutated it should be cloned prior to the rename operation.
|
@Josiah Can you add a test that fails without this change? |
|
@shinnn I've added a failing test This covers the basic scenario in which I was experiencing this bug. |
|
+1 - this should have been happening |
|
Oh, I forgot I can merge this. Thanks! |
yocontra
pushed a commit
that referenced
this pull request
Oct 6, 2015
Clone the original file prior to renaming
|
Could you publish this change to npm also? Lack of it introduces some very hard to debug problems! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file object is being mutated it should be cloned prior to the rename operation. Otherwise if there are other pipelines modifying the same file the clone could be applied twice.
This makes the results of the rename immutable.