Skip to content

Commit

Permalink
exclude package-lock
Browse files Browse the repository at this point in the history
  • Loading branch information
@yocontra
yocontra committed May 15, 2018
1 parent 8d4eecc commit 239c2b6
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3,354 deletions.
1 change: 1 addition & 0 deletions .gitignore
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
.DS_Store
node_modules/
temp/
package-lock.json
Loading

3 comments on commit 239c2b6

@simonua
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@contra, wouldn't you want package-lock.json in GIT, so that you get reproducible installs for when developers make contributions? Rather, add package-lock.json to .npmignore, so it's not included in the package.

@yocontra
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonua There are many opinions about this, but in my projects I never include package-lock (mostly because I don't like the extra noise these add to diffs, and the annoyance of updating it). I think most people share the opinion that package-lock is only useful for projects, not packages.

@simonua
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got you. Thank you for the response, @contra.

Please sign in to comment.