Fix Unknown Artist for YouTube videos #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks and apologies for the delay! |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jun 18, 2022
https://build.opensuse.org/request/show/983511 by user mia + dimstar_suse - Update to 0.8.1 * Fix Unknown Artist for YouTube videos #gh/hoyon/mpv-mpris#76 * Emit signal for fullscreen event #gh/hoyon/mpv-mpris#78 - Update to 0.7.1 * Add test suite * Emit Stopped Signal on exit. #gh/hoyon/mpv-mpris#61 #gh/hoyon/mpv-mpris#22 * Set xesam:artist to channel name for YouTube videos. #gh/hoyon/mpv-mpris#50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to MPRIS protocol,
xesam:artistis a list of strings and not string and thus, when a youtube video is played in mpv, GNOME shell saysReceived faulty track artist metadata from org.mpris.MediaPlayer2.mpv; expected an array of strings, got <artistname> (string)So just changed
add_metadata_item_stringtoadd_metadata_item_string_listand it works fine when I tested.