This repository has been archived by the owner on Jun 8, 2022. It is now read-only.
Fix symlink create notifications on Linux #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The linux code used to ignore events on the files that os.Stat reports as non existing. This ignores the CREATEion of broken links, but monitoring those can be useful, for example /proc/<pid>/fd/ contains fake links for all sockets. The patch simply replaces os.Stat with os.Lstat to solve the issue. I updated the fsnotify_symlink_test.go to what I consider the correct behavior but unfortunately couldn't test under windows, so I'm not sure if it breaks the test there or not.
|
Looks good to me. Test works on BSD too. The test is skipped on Windows, so we're good there too. Thanks. |
rsc
pushed a commit
to golang/exp
that referenced
this pull request
Dec 7, 2014
WatchFlags of files created in Watched directories are now the same as the parent directory. (howeyc/fsnotify#33) Darwin now uses EVT_ONLY flag on Open file for watching. (howeyc/fsnotify#44) Linux has been updated to ignore events that occur after delete. (howeyc/fsnotify#36) Symlink test updated. (howeyc/fsnotify#42) Rename tests use external "mv" where available. R=golang-dev, dave, fullung, rsc CC=golang-dev https://golang.org/cl/9827046
GoogleCodeExporter
pushed a commit
to bsed/go-zh.exp
that referenced
this pull request
May 31, 2015
WatchFlags of files created in Watched directories are now the same as the parent directory. (howeyc/fsnotify#33) Darwin now uses EVT_ONLY flag on Open file for watching. (howeyc/fsnotify#44) Linux has been updated to ignore events that occur after delete. (howeyc/fsnotify#36) Symlink test updated. (howeyc/fsnotify#42) Rename tests use external "mv" where available. R=golang-dev, dave, fullung, rsc CC=golang-dev https://codereview.appspot.com/9827046 Committer: Russ Cox <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linux code used to ignore events on the files that os.Stat reports as
non existing. This ignores the CREATEion of broken links, but monitoring
those can be useful, for example /proc//fd/ contains fake links
for all sockets.
The patch simply replaces os.Stat with os.Lstat to solve the issue.
I updated the fsnotify_symlink_test.go to what I consider the correct
behavior but unfortunately couldn't test under windows, so I'm not sure
if it breaks the test there or not.