This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Set 0.0.0.0 to default hostname #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The node http module, which express inherits from, use 0.0.0.0 as the default (as described here: https://nodejs.org/api/http.html#http_server_listen_port_hostname_backlog_callback) > If the hostname is omitted, the server will accept connections on any IPv6 address (::) when IPv6 is available, or any IPv4 address (0.0.0.0) otherwise.
|
👍 |
|
@EliKrumholz Thank you for catching this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #492. Using a default hostname of 127.0.0.1 overrides the http module's expected default hostname as described here: https://nodejs.org/api/http.html#http_server_listen_port_hostname_backlog_callback. This can cause deployment errors on services such as heroku.