This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Reconnect when websocket closes abnormally #274
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been debugging some websocket connection issues that we've seen pretty consistently on Beep Boop where the connection lasts 6 or 7 days, then disconnects, and doesn't attempt to reconnect. I've narrowed this down to the following scenario:
PONG
receipt times outclose
event triggers on the websocket with an error code1006
with this unsuccessful reconnect attept, meaning it was an abormal close (more info here)Currently that's where the websocket reconnect attempt stops, so this PR adds another reconnect attempt when an abnormal close event is received on the websocket. We've seen this fix our slack rtm connections going down on a few bots on Beep Boop.
Below are some annotated logs that helped me figure out what was going on: