This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Fix crash upon receiving Facebook emoji or like in conversation #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure the values from the postback.
allow facebook attachments
|
Hey @crummy @tkornblit I have added the key features from these pull requests. Since there's some other stuff in here, I'm not going to officially merge this PR. BUT, master now includes the fix for allowing attachment in convos, as well as the ability to hear a postback as a response to a convo.ask! Cool stuff good job. |
|
Thanks, I didn't realise adding to my branch after a pull request would add to the pull request itself. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #219
I'm not very familiar with JS so there's likely to be a better way to do this, but this hack prevents the crash detailed in the issue above.