This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Next Release #1929
Merged
Next Release #1929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes sending `files` key with empty string value when there are no files while sending a message. `files` key with empty string is causing API to fail with below `BadRequest: "Unable to retrieve content."`. I have validated that by sending request to webex api from webex developer console. Signed-off-by: Vivek Singh <[email protected]>
Changes to this file are based on an additional Slack adapter option of "oauthVersion". This would allow for oauth v2 support with minimal changes to the adapter. Updates to this file include 2 conditional statements to use new oauth v2 if options.oauthVersion == 'v2', and updates to example oauth response in the comments.
New slack apps will use oauth v2 by default, we can explain the discrepancy to help devs get up and running faster.
This was referenced Mar 11, 2020
Closed
This was referenced Mar 11, 2020
This was referenced Mar 11, 2020
…the handlers to fire without interferring with the following message in the dialog
|
Excited for this! 🙌I'm updating my bot from botkit 0.4 to latest and also updating scopes using V2 OAuth and this release a critical piece of it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
askhandlers Support entire message objects in convo handlers. Fixes #1793 and #1710 #1801 Bump jquery from 3.4.1 to 3.5.1 in /packages/docs #1973fileskey with empty string value #1906ask()handler causes a message to be skipped #1932