Merge pull request #440 from drhayes/master

Don't use JSON.parse/stringify to clone.
howdyai · Nov 7, 2016 · 47ea1ef · 47ea1ef
2 parents 8e8ffcc + d3bbf02
commit 47ea1ef
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/lib/CoreBot.js b/lib/CoreBot.js
@@ -8,6 +8,7 @@ var simple_storage = require(__dirname + '/storage/simple_storage.js');
 var ConsoleLogger = require(__dirname + '/console_logger.js');
 var LogLevels = ConsoleLogger.LogLevels;
 var ware = require('ware');
+var clone = require('clone');
 
 var studio = require('./Studio.js');
 
@@ -457,7 +458,7 @@ function Botkit(configuration) {
 
         this.cloneMessage = function(message) {
             // clone this object so as not to modify source
-            var outbound = JSON.parse(JSON.stringify(message));
+            var outbound = clone(message);
 
             if (typeof(message.text) == 'string') {
                 outbound.text = this.replaceTokens(message.text);

diff --git a/package.json b/package.json
@@ -8,6 +8,7 @@
     "back": "^1.0.1",
     "body-parser": "^1.14.2",
     "botbuilder": "^3.2.3",
+    "clone": "2.0.0",
     "command-line-args": "^3.0.0",
     "express": "^4.13.3",
     "https-proxy-agent": "^1.0.0",