Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kraken]: Load disruptions for chaos db #4238

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

kadhikari
Copy link
Contributor

This fix will only solve errors occurred while loading disruptions from chaos database.

  • chaos-proto object are created from the chaos database using a SQL query.
  • While loading ptobject of type line_section and rail_section, the same parent ptobject was re used fetching already created ptobject by ptobject_uri.
  • All the children ptobject except the first one were neglected.
  • Use of ptobject_id instead of ptobject_uri should work for all ptobject types.

Ticket: https://navitia.atlassian.net/browse/NAV-2821

Copy link
Contributor

@pbench pbench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no need to order by pt_object id in the sql request ?

@kadhikari
Copy link
Contributor Author

there is no need to order by pt_object id in the sql request ?
No need as it may break message, channel and channel types cycles.
We fetch well the concerned ptobject from de map

@kadhikari kadhikari requested a review from pbench March 12, 2024 11:39
Copy link

sonarcloud bot commented Mar 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link
Contributor

@pbench pbench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kadhikari kadhikari merged commit 1ca5495 into dev Mar 12, 2024
8 of 9 checks passed
@kadhikari kadhikari deleted the fix_load_disruptions_from_chaos_db branch March 12, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants