Fix DataFusion test and try to make ballista compile #4
Conversation
| @@ -236,7 +236,7 @@ mod tests { | |||
| #[test] | |||
| fn invalid_cast() { | |||
| // Ensure a useful error happens at plan time if invalid casts are used | |||
| let schema = Schema::new(vec![Field::new("a", DataType::Int32, false)]); | |||
| let schema = Schema::new(vec![Field::new("a", DataType::Null, false)]); | |||
There was a problem hiding this comment.
Int32 -> LargeBinary cast is valid in arrow2, therefore I change to another unacceptable case Null here
| @@ -965,7 +965,7 @@ mod tests { | |||
| options: Default::default(), | |||
| }, | |||
| PhysicalSortExpr { | |||
| expr: col("c7", &schema).unwrap(), | |||
| expr: col("c12", &schema).unwrap(), | |||
There was a problem hiding this comment.
The original c7 is not distinguishable enough, i.e. same value exists many times.
There was a problem hiding this comment.
👍 The same thing happens in arrow 6.0 (as pointed out by @houqp ) -- more details here: https://github.com/apache/arrow-datafusion/pull/984/files#r705557467
| "| e | 0.01479305307777301 | 0.9965400387585364 | 0.48600669271341534 | 10.206140546981722 | 21 | 21 |", | ||
| "| c | 0.0494924465469434 | 0.991517828651004 | 0.6600456536439785 | 13.860958726523547 | 21 | 21 |", | ||
| "| d | 0.061029375346466685 | 0.9748360509016578 | 0.48855379387549835 | 8.79396828975897 | 18 | 18 |", | ||
| "| e | 0.01479305307777301 | 0.9965400387585364 | 0.48600669271341557 | 10.206140546981727 | 21 | 21 |", |
There was a problem hiding this comment.
I think this is due to float nature of inaccuracy, therefore acceptable.
yjshen
changed the title
yjshen
changed the title
| @@ -1394,7 +1394,7 @@ mod tests { | |||
| let expr = col("b1").not().eq(lit(true)); | |||
| let p = PruningPredicate::try_new(&expr, schema).unwrap(); | |||
| let result = p.prune(&statistics).unwrap(); | |||
| assert_eq!(result, vec![true, false, false, true, true]); | |||
| assert_eq!(result, vec![true, true, false, true, true]); | |||
There was a problem hiding this comment.
interesting, looks like arrow2 fixed a bug that exists in arrow-rs?
There was a problem hiding this comment.
I didn't get too much background on this, since this is a test against pruning of a != true, I think the current behavior is expected
* wip * more * Make scalar.rs compile * Fix various compilation error due to API difference * Make datafusion core compile * fmt * wip * wip: compile ballista * Pass all datafusion tests * Compile ballista
No description provided.