Activate script tags from turbo frames #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 2, 2021 10:25
… return an iterable NodeList
|
I'm kinda anxious for this fix, when can we see this in production guys? 👋 |
|
@xtr3me Can you have a look at the test failure? |
|
@dhh I will look into this, before the end of this week. I'm currently in the midst of a renovation of the house, so I need to find some spare time to address this. |
|
@dhh I have fixed the test failure. I did need to add an additional file as clicking on the link did not trigger an Turbo call anymore if it was clicked once before. By changing the url of the link embedded in the response frame it worked again. |
demir
added a commit
to demir/pinmapper
that referenced
this pull request
Oct 16, 2021
turbo stream ile değiştirilen script kodu çalışmadığı için geçici bir çözüm üretilmiştir hotwired/turbo#192
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a turbo frame the scripts returned from a turbostream are not evaluated and therefor not executed.
This PR adds the functionality to activate these script tags after they are inserted into the turbo-frame.
Fixes #186 for turbo-frames
Please let me know if additional fixes are needed for turbostream elements, I will add them accordingly 👍