Reloading a morphing frame should trigger reloads on its child morphing frames recursively #1311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks, here's what seems to me to be the next obvious step after #1192 changed
reload()
to morph a morphing frame.Example scenario
Imagine the following page structure: a morphing page with a morphing frame that itself includes another morphing frame, i.e.
Status Quo
Refreshing
Morphing Page
already triggers morphingreload()
s on both theMorphing Frame Child
and onMorphing Frame Grandchild
. However, manually triggeringreload()
onMorphing Frame Child
does NOT trigger areload()
onMorphing Frame Grandchild
, but rather does a full non-morphing render. This seems inconsistent and surprising.With this PR
Morphing pages now only trigger
reload()
s on their immediate morphing frame children, and then leaves it up to them to triggerreload()
s on their own immediate morphing frame children, and so on down. This makes the reload behavior consistent no matter where the reload is initially triggered.What do you think?