Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix turbo-confirm for links without a turbo-method #1266

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix turbo-confirm for links without a turbo-method #1266

wants to merge 4 commits into from

Commits on May 26, 2024

  1. Reproduce issue with functional tests

    @tpaulshippy
    tpaulshippy committed May 26, 2024
    Configuration menu
    Copy the full SHA
    3ce94fe View commit details
    Browse the repository at this point in the history

  2. Make link text unique in test page

    @tpaulshippy
    tpaulshippy committed May 26, 2024
    Configuration menu
    Copy the full SHA
    6f23034 View commit details
    Browse the repository at this point in the history

  3. Use FormLinkClickObserver when link has data-turbo-confirm attribute 

    - This makes the confirmation work even if data-turbo-method is not present
    @tpaulshippy
    tpaulshippy committed May 26, 2024
    Configuration menu
    Copy the full SHA
    85ff371 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Remove extra tests 

    - These were for illustrating the workaround, but probably aren't needed in the suite longer term
    @tpaulshippy
    tpaulshippy committed May 28, 2024
    Configuration menu
    Copy the full SHA
    a149541 View commit details
    Browse the repository at this point in the history