Prevent Refresh from interrupting ongoing Visit #1213
Conversation
|
Thank you for this! I've been unable to reproduce #1209 with these changes applied and everything else seems to still be functioning properly. Really appreciate the quick response! |
|
@afcapel @jorgemanrubia are either of you available to review this change? |
src/core/drive/navigator.js
Outdated
| @@ -125,6 +125,7 @@ export class Navigator { | |||
|
|
|||
| visitCompleted(visit) { | |||
| this.delegate.visitCompleted(visit) | |||
| this.stop() | |||
There was a problem hiding this comment.
I see that, before, it was invoking stop only when starting visits and submitting forms. This looks correct but, since this is a pretty important path, any concerns about introducing unwanted side effects here? I can't think of anything in particular, but concerned about interrupting form submissions we were not interrupting before.
There was a problem hiding this comment.
This looks correct but, since this is a pretty important path, any concerns about introducing unwanted side effects here?
Now that you mention it, a Visit initiated by a link click is guaranteed to either do nothing (when canceled) or navigated. A form, on the other hand, has the potential to complete and succeed without navigating when handling stream responses. The same is true for a link click with [data-turbo-stream].
Acknowledging that, what is the desired order of operations for a Page Refresh that's competing with a Stream form submission?
It feels like the Visit should always win out, since that's requesting the most (and most up-to-date) content. Is that correct?
There was a problem hiding this comment.
@jorgemanrubia I've pushed up a change to remove the call to this.stop(), and replace it with delete this.currentVisit.
There was a problem hiding this comment.
@jorgemanrubia are you available to re-review this?
seanpdoyle
force-pushed
the
issue-1209
branch
2 times, most recently
from
be4c81f
to
19267e7
Compare
Closes [hotwired#1209] Defers the `Session.refresh` calls while handling `<turbo-stream action="refresh">` elements if there is a `Visit` that's already initiated and being handled by the `Navigator`. [hotwired#1209]: hotwired#1209
|
This one is good to merge @afcapel from my side. |
|
I'm not sure this resolves the issue. I have reported a similar issue separately and after @seanpdoyle 's notification tested this patch, but it does not prevent the interruption in my test app. |
Actually these are most likely two separate issues. The issue I was referring to and opened a PR for is a scenario where user navigation succeeds but is then overridden by a debounced refresh from previous page. This one is about interrupting in-progress visits. So this is well worth merging 👍 |
Closes #1209
Defers the
Session.refreshcalls while handling<turbo-stream action="refresh">elements if there is aVisitthat's already initiated and being handled by theNavigator.