Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autofocus tests are flaky #1154

Closed
afcapel opened this issue Feb 1, 2024 · 2 comments · Fixed by #1219
Closed

Autofocus tests are flaky #1154

afcapel opened this issue Feb 1, 2024 · 2 comments · Fixed by #1219

Comments

@afcapel
Copy link
Collaborator

afcapel commented Feb 1, 2024

The often fails on CI, for example https://github.com/hotwired/turbo/actions/runs/7723792974/job/21054601474
@afcapel
Copy link
Collaborator Author

afcapel commented Feb 2, 2024

Another failure https://github.com/hotwired/turbo/actions/runs/7755348058/job/21150514185

@afcapel afcapel mentioned this issue Feb 9, 2024
Merged
seanpdoyle added a commit to seanpdoyle/turbo that referenced this issue Mar 3, 2024
@seanpdoyle
Use Playwright assertions for autofocus
239de0b 
Closes [hotwired#1154][]

Replace bespoke CSS selector-based assertions with Playwright's built-in
[toBeFocused](https://playwright.dev/docs/api/class-locatorassertions#locator-assertions-to-be-focused)
assertion.

Like other assertions, `toBeFocused` will wait and retry for a period of
time, which makes `nextBeat` calls unnecessary.

[hotwired#1154]: hotwired#1154
@seanpdoyle seanpdoyle mentioned this issue Mar 3, 2024
Merged
@seanpdoyle
Copy link
Contributor

I've opened #1219 to try and address this.

afcapel pushed a commit that referenced this issue Mar 5, 2024
@seanpdoyle
Use Playwright assertions for autofocus (#1219)
8c66861 
Closes [#1154][]

Replace bespoke CSS selector-based assertions with Playwright's built-in
[toBeFocused](https://playwright.dev/docs/api/class-locatorassertions#locator-assertions-to-be-focused)
assertion.

Like other assertions, `toBeFocused` will wait and retry for a period of
time, which makes `nextBeat` calls unnecessary.

[#1154]: #1154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Playwright assertions for autofocus seanpdoyle/turbo
2 participants
@afcapel @seanpdoyle