Ensure turbo-stream[action="remove"] does not render a view partial by default
#680
+36
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes [hotwired#679][] Prior to this change, calls to `Turbo::Streams::Broadcasts#broadcast_remove_to` would render a view partial that corresponds to the model *regardless* of whether or not the contents of that render would be included in the broadcast `<turbo-stream>` element. Not only is it wasteful to render HTML and then do nothing with it, it also poses the risk of failing due to errors raised during the rendering process. This commit restructures the contents of the `Turbo::Streams::Broadcasts#broadcast_action_to` method to skip extraneous rendering if `render: false` is passed. In addition, it ensures that calls to `broadcast_remove_to` pass `render: false` by default. [hotwired#679]: hotwired#679
seanpdoyle
changed the title
turbo-stream[action="remove"] does not renderturbo-stream[action="remove"] does not render a view partial
seanpdoyle
changed the title
turbo-stream[action="remove"] does not render a view partialturbo-stream[action="remove"] does not render a view partial by default
|
@jorgemanrubia @brunoprietog are either of you available to review this? |
brunoprietog
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #679
Prior to this change, calls to
Turbo::Streams::Broadcasts#broadcast_remove_towould render a view partial that corresponds to the model regardless of whether or not the contents of that render would be included in the broadcast<turbo-stream>element.Not only is it wasteful to render HTML and then do nothing with it, it also poses the risk of failing due to errors raised during the rendering process.
This commit restructures the contents of the
Turbo::Streams::Broadcasts#broadcast_action_tomethod to skip extraneous rendering ifrender: falseis passed. In addition, it ensures that calls tobroadcast_remove_topassrender: falseby default.