ci: Automate requesting review #656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds a simple github action that automates requesting review from @jorgemanrubia and @seanpdoyle on PR's that passes CI
omarluq
force-pushed
the
automate-reviews
branch
from
5c92909
to
b63eb2d
Compare
seanpdoyle
reviewed
Aug 1, 2024
| with: | ||
| github-token: ${{secrets.GITHUB_TOKEN}} | ||
| script: | | ||
| const reviewers = ['seanpdoyle', 'jorgemanrubia']; |
There was a problem hiding this comment.
I'm flattered to be included in this list.
With that being said, I am not a project maintainer, and do not have permissions to merge or close pull requests.
There was a problem hiding this comment.
Your opinions and feedback are valuable imho and defiantly should be on the list.
However hardcoding usernames on github actions is bad practice, this pr is to stir up a convo about this but ideally there should be a github team that the maintainers controller membership to and gets tagged instead IMHO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a simple github action that automates requesting review from @jorgemanrubia and @seanpdoyle on PR's that passes CI