Raise exception when no id is passed to the turbo_frame_tag helper #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
approved these changes
Jan 8, 2024
seanpdoyle
reviewed
Jan 8, 2024
Co-authored-by: Sean Doyle <[email protected]>
|
@seanpdoyle great suggestion - PR updated. |
|
@seanpdoyle - let me know if you need any other updates to the PR. |
seanpdoyle
approved these changes
Feb 25, 2024
|
@jorgemanrubia could you approve this PR so for CI? |
brunoprietog
requested changes
Jul 13, 2024
There was a problem hiding this comment.
Hi @thiagopradi, thanks for your contribution! I left a minor suggestion and i'll merge
| @@ -21,6 +21,26 @@ class Turbo::FramesHelperTest < ActionView::TestCase | |||
| assert_dom_equal %(<turbo-frame id="message_1"></turbo-frame>), turbo_frame_tag(record) | |||
| end | |||
|
|
|||
| test "frame with invalid argument should raise ArgumentError" do | |||
There was a problem hiding this comment.
The record variables could be ignored here and pass the argument directly. I don't see much value in declaring them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Folks,
This PR was created after I went through a debug session to see why one of my Turbo frames was not working correctly. I've misspelled one of the instance variables, and Turbo created a frame with an empty id.
After thinking for a little bit, I couldn't think of a use case where it's expected/intended to create a turbo frame with an empty tag, so I created a pull request that raises
ArgumentErrorif a valid ID is not passed. (please correct me If there's any use case where we expect to create a turbo frame with empty IDs).Thiago