Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR originates from a difficult debugging session I had.
In my model I had a typo:
and used
@chatroom
instead ofchatroom
. This error lead to an emptystreamables
array ([nil]
) and the broadcasting was not working.The error symptoms were:
where you can see that the final stream name ends up being simply
:
. I had therefore an hard time to spot the issue.This PR is very aggressive, and simply raises in such a context, maybe we would like a lighter (error message) approach? I think that if we have an empty streamables array is most probably an error.