Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionCable required even when not using streams #74

Closed
stgm opened this issue Jan 8, 2021 · 2 comments
Closed

ActionCable required even when not using streams #74

stgm opened this issue Jan 8, 2021 · 2 comments

Comments

@stgm
Copy link

stgm commented Jan 8, 2021

After switching to production I was required to include Action Cable because this gem's app/channels/turbo/streams_channel.rb depends on it.

I am not using streams at all, so I'm wondering if this dependency is avoidable?

@dhh
Copy link
Member

dhh commented Jan 8, 2021

This gem is 90% wrapping for streams. So if you don't need streams, you can just use the JS library directly.

@dhh dhh closed this as completed Jan 8, 2021
@stgm
Copy link
Author

stgm commented Jan 8, 2021

Oh that makes sense!

boardfish added a commit to ViewComponent/view_component that referenced this issue Aug 17, 2024
joelhawksley added a commit to ViewComponent/view_component that referenced this issue Aug 20, 2024
* Add failing test for rendering turbo stream tags

* Skip Turbo test on Rails < 6

* Use Appraisal to only load turbo-rails for compatible versions

* Don't error if turbo-rails is required on an unsupported Rails version

* Add turbo-rails for rails-7.1 appraisal, regenerate lockfiles

* Re-add `end` tag that went missing in the rebase

* Make test pass and document

* Verify capture compatibility patch fixes this

* Require action_cable to navigate hotwired/turbo-rails#74

* Lint

* Remove lingering Rails 5.2/6.0 support

* Update docs/CHANGELOG.md

---------

Co-authored-by: Joel Hawksley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants