Refactor Event Options test helpers #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 1, 2022 14:02
... and modify `actionValue` to accept an element onto which the action should be set. Defaults to `this.element` when the element isn't provided.
... that has the same method signature as the `triggerEvent` method.
|
@dhh Can we merge this PR if everything looks okay? Is there anything else that needs to be done? |
marcoroth
approved these changes
May 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the following lines of code:
stimulus/src/tests/modules/core/event_options_tests.ts
Lines 193 to 199 in 30933d6
and replace it with a new method called
setActionthat accepts anElementonto which to set the action. This is similar in signature totriggerEvent.Resolves the conversation: #535 (comment).