Merge pull request #5889 from facebook/chore/eslint-valid-typeof

Fix eslint warnings for valid-typeof
hotosm · Jun 22, 2023 · d1e1c9f · d1e1c9f
2 parents 9582691 + 102227e
commit d1e1c9f
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 9 deletions.
diff --git a/frontend/src/components/editor.js b/frontend/src/components/editor.js
@@ -11,7 +11,7 @@ export default function Editor({ setDisable, comment, presets, imagery, gpxUrl }
   const iDContext = useSelector((state) => state.editor.context);
   const locale = useSelector((state) => state.preferences.locale);
   const [customImageryIsSet, setCustomImageryIsSet] = useState(false);
-  const windowInit = typeof window !== undefined;
+  const windowInit = typeof window !== 'undefined';
   const customSource =
     iDContext && iDContext.background() && iDContext.background().findSource('custom');
 

diff --git a/frontend/src/components/rapidEditor.js b/frontend/src/components/rapidEditor.js
@@ -18,7 +18,7 @@ export default function RapidEditor({
   const RapiDContext = useSelector((state) => state.editor.rapidContext);
   const locale = useSelector((state) => state.preferences.locale);
   const [customImageryIsSet, setCustomImageryIsSet] = useState(false);
-  const windowInit = typeof window !== undefined;
+  const windowInit = typeof window !== 'undefined';
   const customSource =
     RapiDContext && RapiDContext.background() && RapiDContext.background().findSource('custom');
 

diff --git a/frontend/src/components/teamsAndOrgs/teams.js b/frontend/src/components/teamsAndOrgs/teams.js
@@ -316,11 +316,7 @@ export function TeamSideBar({ team, members, managers, requestedToJoin }: Object
       showLoadingAnimation={true}
       type="media"
       rows={20}
-      ready={
-        typeof team.teamId === 'number' &&
-        typeof organisations !== undefined &&
-        typeof pmTeams !== undefined
-      }
+      ready={typeof team.teamId === 'number'}
     >
       <div className="cf pb2">
         <div className="w-20 pv2 dib fl">

diff --git a/frontend/src/components/user/content.js b/frontend/src/components/user/content.js
@@ -57,7 +57,7 @@ export function OSMCard({ username }: Object) {
               showLoadingAnimation={true}
               rows={1}
               delay={100}
-              ready={typeof osmUserInfo !== undefined}
+              ready={typeof osmUserInfo !== 'undefined'}
             >
               <FormattedRelativeTime value={value} unit={unit} />
             </ReactPlaceholder>
@@ -72,7 +72,7 @@ export function OSMCard({ username }: Object) {
               showLoadingAnimation={true}
               rows={1}
               delay={100}
-              ready={typeof osmUserInfo !== undefined}
+              ready={typeof osmUserInfo !== 'undefined'}
             >
               <FormattedNumber value={osmUserInfo ? osmUserInfo.changesetCount : 0} />
             </ReactPlaceholder>