Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding additional user info to user page #538

Closed
wants to merge 5 commits into from
Closed

Adding additional user info to user page #538

wants to merge 5 commits into from

Conversation

ethan-nelson
Copy link
Collaborator

#326 lists a few things that would be great to have on the user page regarding a user's OSM history. Also #300 alludes to some of this. I've added to the user profile:

  • User join date (hovering over gives full string)
  • Total changesets
  • Direct link to OSM edits

users

When you are viewing a user page that's not your own, the join date string should be in line with the profile link.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 95.3% when pulling 0bbb2e9 on ethan-nelson:dev20 into 13ae34d on hotosm:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 95.3% when pulling 0bbb2e9 on ethan-nelson:dev20 into 13ae34d on hotosm:master.

@ethan-nelson
Copy link
Collaborator Author

Could probably use some better error handling in the event it cannot get a response from the OSM API, but took a first jab at it.

@pyrog
Copy link
Contributor

pyrog commented Jan 23, 2015

Total changesets

It could interesting to display also the numbers of changesets made for hot.
Search changesets with comments start with #hotosm-task

See drolbr/Overpass-API#189

@bgirardot
Copy link
Contributor

Just to note, recent TM2 updates changed #hotosm-task to #hotosm-project for newly created projects to match the naming convention we use, program -> project -> task

@ethan-nelson
Copy link
Collaborator Author

@pyrog yes it would be great to have HOT changesets, but I feel it's hard to discern fully those that count for that. It wouldn't count any changesets someone made without those labels (I know I did that many times with v1 tasks) or ones with the url enconding issue. And also I don't know if it's a fully representative metric. Sometimes people upload a single changeset for every node edit while others do only one for a full task. That said, I don't know of a fairer or more accurate metric either...perhaps number of objects edited within the bboxes of every task they worked on or total up the number of tasks over all the projects. I'd make a new issue for this request specifically as it will require much more code anyway.

${_('This user joined OSM on ${join_date}.', mapping={'join_date':creation_date[5:7] + \
'/' + creation_date[8:10] + '/' + \
creation_date[0:4]})}
</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be great to have localized dates.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acknowledged. Will work on this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't forgotten about this :) got busy with work, but will get back to this soon.

@ethan-nelson
Copy link
Collaborator Author

Closing to reopen for i18n addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants