Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Vespucci Editor for mobile mapping #578

Merged
merged 10 commits into from
Jul 18, 2019
Merged

Added Vespucci Editor for mobile mapping #578

merged 10 commits into from
Jul 18, 2019

Conversation

mmlmendoza
Copy link
Contributor

I've noticed there's no guide for using Vespucci in the learnosm site. Made one since Vespucci is a good app for mobile mapping in Android and it's what I also use.

@Nick-Tallguy
Copy link
Collaborator

Nick-Tallguy commented Jul 11, 2019 via email

@Nick-Tallguy
Copy link
Collaborator

Hi,
I've had a quick look through, and it's looking good, but can I get you to make a few changes please. Our target audience is often in parts of the world with poor internet access, and we therefore have an image restriction of 800 pixels on the longest edge for any images. A quick look shows many of your images are far larger than this, and will slow or stop the site considerably if internet access is poor. Please reduce the images to 800px along longest edge.

_posts/en/0900-07-20-vespucci_en.md
Please make the following amendments;
line 49, add a space after the )
line 103, I think the last sentence should read "A new node will be added in the selected location."
line 124, I think this should read "Select what you want to redo."

Thanks for working on this.

Regards

Nick

@mmlmendoza
Copy link
Contributor Author

Hi,
I've had a quick look through, and it's looking good, but can I get you to make a few changes please. Our target audience is often in parts of the world with poor internet access, and we therefore have an image restriction of 800 pixels on the longest edge for any images. A quick look shows many of your images are far larger than this, and will slow or stop the site considerably if internet access is poor. Please reduce the images to 800px along longest edge.

_posts/en/0900-07-20-vespucci_en.md
Please make the following amendments;
line 49, add a space after the )
line 103, I think the last sentence should read "A new node will be added in the selected location."
line 124, I think this should read "Select what you want to redo."

Thanks for working on this.

Regards

Nick

Hi! I've already edited my work based on your comments. I've already updated the _posts/en/0900-07-20-vespucci_en.md and reduced the dimensions of all the images.

This is my first contribution on GitHub so thank you for checking!

@Nick-Tallguy Nick-Tallguy merged commit c9b9a34 into hotosm:gh-pages Jul 18, 2019
@Nick-Tallguy
Copy link
Collaborator

Hi @mmlmendoza I've pulled your work into the site, but at the moment the images are not displaying. I think you have named the images *.PNG, but in the .md file you have referenced them as .png - I can't work on this at the moment, but may have internet access later today or tomorrow. If you are able to correct this, that would be good, if not I'll work on it when I can.

Regards

Nick

@mmlmendoza
Copy link
Contributor Author

mmlmendoza commented Jul 19, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmlmendoza @Nick-Tallguy @feyeandal