-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CONTRIBUTING.md #327
Conversation
add links to conventions and guidelines for contributing
@althio - Looks pretty good to me. Not sure if we should go with the system outlined for the image filing though. I think @pyrog is advocating something slightly different & I'm keen to hear his advice. At the moment we seem to be part way between:
1/. I don't like because of the /section/ folder - one of the advantages we are trying to achieve is the ability to quickly create a new 'index' so that a section appears elsewhere. If we have a /section/ folder we defeat that. If we're going to alter the image storage system, perhaps now is the time to update the documentation - which is wrong anyway according to what we've got. The wiki reads as if it was aimed at converting google docs into markdown docs for creating the site. Although interested it may be time to do some drastic altering. Personally when I'm adding images I'm creating them using a variety of steps, avoiding having any writing in them at all (so they can be used in all language versions) and using Gimp to reduce them to 520px - there is discussion in one of the issues about this and I think the consensus I would go for is 'use whatever software you find easiest so you end up with an image of no more than 520px' If we update the wiki &/or contributing.md now so it shows the system we are aiming for, we will know what to do in the future, and hopefully not have conflicting advice. |
In "my" sandbox, I use only one image folder but there will be to many images. But I prefer to avoid language subfolder and use a language extension (See Content negotiation concept).
If an image is "neutral language" (like a picture of a mapper using a gps receiver) all "translations" use the "english" image ( But if the image contain important text or have a cultural meaning, for example french translation of a chapter use |
I agree it is only a feeble attempt to document the current (and partly
outdated) guidelines and publicise them.
I am very happy that it triggers such an inspiring discussion on image
filing. It appears certainly to be the messy part for the time being. The
wiki is only labeled "guidelines-beta" so it clearly implies that everyone
is aware it is not finalised yet.
I would like to merge this PR then, as a first step for the current and any
future documentation.
@Nick-Tallguy @pyrog
Could you please copy/paste your insightful comments on image filing into
an new issue or an outstanding issue, such as #94 or #113?
|
add links to conventions and guidelines for contributing