Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SQLAlchemy and GeoAlchemy #23

Merged
merged 7 commits into from
Jan 21, 2024
Merged

Remove SQLAlchemy and GeoAlchemy #23

merged 7 commits into from
Jan 21, 2024

Conversation

spwoodcock
Copy link
Member

@spwoodcock spwoodcock commented Jan 21, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Issue

Fixes #22

Describe this PR

  • Removes dependencies SQLAlchemy and GeoAlchemy.
  • Replaced with direct psycopg2 driver usage.
  • The rationale was described in the issue: to reduce subdependencies when installing fmtm-splitter (for users that don't use SQLAlchemy).
  • I also fixed all the linting errors for pre-commit.

@spwoodcock spwoodcock self-assigned this Jan 21, 2024
@github-actions github-actions bot added the dependency Includes a dependency change label Jan 21, 2024
@github-actions github-actions bot added docs Improvements or additions to documentation devops labels Jan 21, 2024
@spwoodcock
Copy link
Member Author

I will merge this and make a pre-release for incorporating in FMTM.
(the release will be breaking --> 1.x.x)

Feel free to test/review & we can always update prior to the actual release.

@spwoodcock spwoodcock merged commit 45c23e6 into main Jan 21, 2024
5 checks passed
@spwoodcock spwoodcock deleted the feat/remove-sqlalchemy branch January 21, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Includes a dependency change devops docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor out SQLAlchemy
1 participant