-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model Creation & Edit, Banner and Start Mapping Layout #301
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jeafreezy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeafreezy the amount of dependencies is increasing rapidly, let's just make sure we are using community supported libs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Roger that.
Thanks for your concern @omranlm . The new additions are:
- terraformer/wkt: We need it to convert the AOI to WKT. (Necessary)
- @turf/area: We need it to calculate the area for the AOI. (Necessary)
- @turf/bbox: We need it to get the bounds for the AOI. (Necessary)
- react-dropzone: We need it for the AOI file's drag-and-drop dialog functionality. (Not really necessary - we can allow the users to just open their file picker when they click on the 'upload' button. However, I must admit that it provides a better UX.)
- react-confetti-explosion: When the model creation is successful, we need it for the confetti explosion. (Not really necessary, too. However, I must also admit that it provides a good UX).
- terra-draw: For drawing functionality. (Necessary)
Some suggestions:
The top three can be delegated to the backend later in the future, therefore eliminating the dependencies.
- Send the raw AOI GeoJSON feature directly to the backend instead of transforming it to WKT on the client.
- The backend should calculate the area and return it as part of the GeoJSON feature properties.
- The backend should return the bbox as properties of the GeoJSON feature.
Rest assured, I will ensure all dependencies are community-supported libs and lightweight.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions:
The top three can be delegated to the backend later in the future, therefore eliminating the dependencies.
Send the raw AOI GeoJSON feature directly to the backend instead of transforming it to WKT on the client.
The backend should calculate the area and return it as part of the GeoJSON feature properties.
The backend should return the bbox as properties of the GeoJSON feature.
@jeafreezy Raise this as an issue ! I will resolve when I can
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this PR do ?
This PR implements the model creation flow. The following features are implemented:
How to Test
Visit: https://f-a-ir-emmanuels-projects-1886bda9.vercel.app/