Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model Creation & Edit, Banner and Start Mapping Layout #301

Merged
merged 99 commits into from
Nov 25, 2024

Conversation

jeafreezy
Copy link
Collaborator

@jeafreezy jeafreezy commented Oct 31, 2024

What does this PR do ?

This PR implements the model creation flow. The following features are implemented:

  1. Model creation and update.
  2. Training dataset creation and selection.
  3. Training area: Drawing, Upload, Delete, Open in ID Editor, Open in JOSM, Fetching of Labels.
  4. Training Settings Configurations.
  5. Training request submission.
  6. Model enhancement
  7. Banner
  8. Start mapping layout
  9. and many more.

How to Test

Visit: https://f-a-ir-emmanuels-projects-1886bda9.vercel.app/

@jeafreezy jeafreezy marked this pull request as draft October 31, 2024 14:11
@jeafreezy jeafreezy requested a review from omranlm October 31, 2024 14:11
@jeafreezy jeafreezy mentioned this pull request Nov 1, 2024
Copy link
Contributor

@omranlm omranlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jeafreezy

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeafreezy the amount of dependencies is increasing rapidly, let's just make sure we are using community supported libs

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roger that.

Thanks for your concern @omranlm . The new additions are:

  1. terraformer/wkt: We need it to convert the AOI to WKT. (Necessary)
  2. @turf/area: We need it to calculate the area for the AOI. (Necessary)
  3. @turf/bbox: We need it to get the bounds for the AOI. (Necessary)
  4. react-dropzone: We need it for the AOI file's drag-and-drop dialog functionality. (Not really necessary - we can allow the users to just open their file picker when they click on the 'upload' button. However, I must admit that it provides a better UX.)
  5. react-confetti-explosion: When the model creation is successful, we need it for the confetti explosion. (Not really necessary, too. However, I must also admit that it provides a good UX).
  6. terra-draw: For drawing functionality. (Necessary)

Some suggestions:

The top three can be delegated to the backend later in the future, therefore eliminating the dependencies.

  1. Send the raw AOI GeoJSON feature directly to the backend instead of transforming it to WKT on the client.
  2. The backend should calculate the area and return it as part of the GeoJSON feature properties.
  3. The backend should return the bbox as properties of the GeoJSON feature.

Rest assured, I will ensure all dependencies are community-supported libs and lightweight.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions:

The top three can be delegated to the backend later in the future, therefore eliminating the dependencies.

Send the raw AOI GeoJSON feature directly to the backend instead of transforming it to WKT on the client.
The backend should calculate the area and return it as part of the GeoJSON feature properties.
The backend should return the bbox as properties of the GeoJSON feature.

@jeafreezy Raise this as an issue ! I will resolve when I can

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #304 and #303 .

@jeafreezy jeafreezy changed the title Model creation, Banner and Start Mapping Layout Model Creation & Edit, Banner and Start Mapping Layout Nov 20, 2024
@kshitijrajsharma kshitijrajsharma merged commit 88aaac5 into hotosm:develop Nov 25, 2024
3 checks passed
@jeafreezy jeafreezy deleted the model-creation branch November 25, 2024 19:40
@jeafreezy jeafreezy restored the model-creation branch November 27, 2024 19:50
@jeafreezy jeafreezy deleted the model-creation branch November 27, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants