Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show proper duration for failed trainings #297

Closed
omranlm opened this issue Oct 22, 2024 · 3 comments · Fixed by #298
Closed

Show proper duration for failed trainings #297

omranlm opened this issue Oct 22, 2024 · 3 comments · Fixed by #298
Assignees
Labels
bug Something isn't working component : frontend

Comments

@omranlm
Copy link
Contributor

omranlm commented Oct 22, 2024

Describe the bug
Show empty duration or dash - when there is not finished_at date for a training record to avoid those non sense duration as in the screenshot below

To Reproduce
Steps to reproduce the behavior:

  1. Go to a failed training that doesn't have a finished_at value
  2. see the duration calculation which is calculating wrong value

Expected behavior
Show a "-" or empty value when training is failed and there is not finished_at value

Screenshots

image

@omranlm omranlm added bug Something isn't working component : frontend labels Oct 22, 2024
@omranlm
Copy link
Contributor Author

omranlm commented Oct 22, 2024

@jeafreezy

@omranlm omranlm assigned omranlm and unassigned omranlm Oct 22, 2024
@jeafreezy jeafreezy mentioned this issue Oct 22, 2024
@jeafreezy
Copy link
Collaborator

PR up for this @omranlm . #298

@jeafreezy
Copy link
Collaborator

@jeafreezy

Great catch! Thanks.

@jeafreezy jeafreezy self-assigned this Oct 22, 2024
omranlm added a commit that referenced this issue Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component : frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants