Add support for deprecated items in Chargebee streams #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butkeraites-hotglue
commented
Dec 11, 2024
butkeraites-hotglue
commented
- Introduced 'include_deprecated' configuration option in the main function to control the inclusion of deprecated items.
- Added 'active_id' field to the subscriptions schema for better tracking of active subscriptions.
- Updated CustomersStream and SubscriptionsStream to include 'include_deprecated' parameter in API requests when enabled.
- Introduced 'include_deprecated' configuration option in the main function to control the inclusion of deprecated items. - Added 'active_id' field to the subscriptions schema for better tracking of active subscriptions. - Updated CustomersStream and SubscriptionsStream to include 'include_deprecated' parameter in API requests when enabled.
keyn4
reviewed
Dec 11, 2024
| @@ -15,3 +15,9 @@ class SubscriptionsStream(BaseChargebeeStream): | |||
|
|
|||
| def get_url(self): | |||
| return 'https://{}/api/v2/subscriptions'.format(self.config.get('full_site')) | |||
|
|
|||
| def get_params(self, params): | |||
| params = super().get_params(params) | |||
There was a problem hiding this comment.
I think the code is not entering here because the get_params base function is in ChargebeeClient but the streams inherit from BaseChargebeeStream, at least is not working for me locally
- Added 'include_deprecated' parameter to BaseChargebeeStream for customers and subscriptions. - Removed redundant 'get_params' method overrides in CustomersStream and SubscriptionsStream, as the base class now handles the inclusion of deprecated items. This update improves the flexibility of API requests by allowing the inclusion of deprecated items when specified in the configuration.
keyn4
approved these changes
Dec 12, 2024
hsyyid
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.