Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract out the different types of node in a zipped Rune #434

Merged
merged 6 commits into from
Jun 7, 2022

Conversation

Michael-F-Bryan
Copy link
Contributor

This gives us nice things like the ability to make TensorFlow Lite support optional and helps simplify the ZuneEngine code.

Copy link
Contributor

@saidinesh5 saidinesh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR isn't compiling. So can't merge this right now. plus Most of these changes will be deleted after the wit file cleanup. So let's not merge this today before the demos and create more work for us.

@Michael-F-Bryan
Copy link
Contributor Author

@saidinesh5 this isn't just a bunch of random refactorings. I'm disabling TensorFlow Lite so we unblock the people who can't work on Weld Studio due to hotg-runecoral build issues.

@saidinesh5 saidinesh5 merged commit 41b7bd1 into zune Jun 7, 2022
@saidinesh5 saidinesh5 deleted the refactor/optional-tflite branch June 7, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants