Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #13

Merged
merged 6 commits into from
Apr 17, 2017
Merged

Update dependencies #13

merged 6 commits into from
Apr 17, 2017

Conversation

yshrsmz
Copy link
Collaborator

@yshrsmz yshrsmz commented Apr 14, 2017

Before starting #11 , I updated dependencies to newer ones.

Basically all deps are updated to the latest stable version, but I found that gradle 3.5 or 3.4.1 does not work well with bintray-release, so I decided to use 3.3.

FYI the error looks like this:

A problem occurred configuring project ':library'.
> Failed to notify project evaluation listener.
   > org/gradle/api/internal/component/Usage

yshrsmz
yshrsmz commented Apr 14, 2017
View reviewed changes
compiler/build.gradle
}

publish {
userOrg = USER
groupId = GROUP_ID
artifactId = ARTIFACT_ID_COMPILER
version = VERSION
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these values are now deprecated
https://github.com/novoda/bintray-release/blob/5d67434df5fa72fd22c614dbc766f151abe6de70/core/src/main/groovy/com/novoda/gradle/release/PublishExtension.groovy#L16

@hotchemi
Copy link
Owner

👀

@yshrsmz yshrsmz mentioned this pull request Apr 14, 2017
Closed
@hotchemi
Copy link
Owner

LGTM 💯

@hotchemi hotchemi merged commit 875b7d3 into hotchemi:rxjava2 Apr 17, 2017
@hotchemi
Copy link
Owner

@yshrsmz Thx! probably we should use https://github.com/bintray/gradle-bintray-plugin 🤔

@yshrsmz
Copy link
Collaborator Author

yshrsmz commented Apr 17, 2017

That's a good idea!

@yshrsmz yshrsmz deleted the update_dependencies branch April 17, 2017 11:55
@yshrsmz yshrsmz mentioned this pull request Apr 20, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yshrsmz @hotchemi