REFACTOR+ADD - Show latest incidents option #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #190 +/- ##
============================================
- Coverage 10.16% 9.89% -0.27%
Complexity 23 23
============================================
Files 44 45 +1
Lines 777 798 +21
Branches 48 47 -1
============================================
Hits 79 79
- Misses 694 715 +21
Partials 4 4 |
|
|
Reverted other changes based on #190 (comment)
hossain-khan
added a commit
that referenced
this pull request
Jul 9, 2020
Refactored the navigation args to take in unified args data object with `FilterType` Updated code to support the new `FilterType` and latest incidents view. Added `@Parcelize` kotlin extension feature to pass the data object as parcelable. Closes #188
hossain-khan
added a commit
that referenced
this pull request
Jul 9, 2020
Refactored the navigation args to take in unified args data object with `FilterType` Updated code to support the new `FilterType` and latest incidents view. Added `@Parcelize` kotlin extension feature to pass the data object as parcelable. Closes #188
hossain-khan
force-pushed
the
feature/show-filter-fab-menu
branch
from
c62dba5 to
569d619
Compare
Refactored the navigation args to take in unified args data object with `FilterType` Updated code to support the new `FilterType` and latest incidents view. Added `@Parcelize` kotlin extension feature to pass the data object as parcelable. Closes #188
hossain-khan
force-pushed
the
feature/show-filter-fab-menu
branch
from
569d619 to
83c9557
Compare
|
LGTM for #188 |
hossain-khan
changed the title
hossain-khan
changed the title
|
Final UI
|
hossain-khan
added a commit
that referenced
this pull request
Jul 9, 2020
It doesn't make sense to show all incidents for latest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible solution for #188 #189
Not a fan of overlapping icons at the toolbar. 🤔