Update legacy-juggler-bridge.ts function: toEntity #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update legacy-juggler-bridge.ts function: toEntity(model)
shimks
suggested changes
Jun 22, 2018
There was a problem hiding this comment.
Hi @hosiduy, could you open up the PR against https://github.com/strongloop/loopback-next (the upstream repository)?
Also, we require PRs for strongloop's repositories to have tests added for the code being changed. Could you add in the tests for toEntity in legacy-juggler-bridge.unit.ts?
|
@hosiduy Just wanted to know if you would like to follow this PR up over at https://github.com/strongloop/loopback-next. Please let us know if you need any help with this |
|
@shimks Sorry for late rep. I don't know how to write test for this PR so can you help me with writing test for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update legacy-juggler-bridge.ts function: toEntity(model)
Check whether the model we get back in toEntity is an instance of model or not.
Fixes loopbackio#1419
See also loopbackio#1378
Checklist
npm testpasses on your machinepackages/cliwere updatedpackages/example-*were updated