Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE-690: Allow users to disble server side caching #691

Merged
merged 2 commits into from
Mar 26, 2020
Merged

ISSUE-690: Allow users to disble server side caching #691

merged 2 commits into from
Mar 26, 2020

Conversation

raju-saravanan
Copy link
Collaborator

Fixes #690

akatona84
akatona84 reviewed Mar 23, 2020
View reviewed changes
...stry/core/src/main/java/com/hortonworks/registries/schemaregistry/DefaultSchemaRegistry.java Outdated
}

public Boolean isCacheEnabled() {
return (Boolean) getValue(config, ENABLE_CACHING, Boolean.FALSE);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be enabled by default, to be backward compatible.

@raju-saravanan
Copy link
Collaborator Author

@akatona84: Addressed your review comments.

akatona84
akatona84 reviewed Mar 24, 2020
View reviewed changes
Copy link
Contributor

@akatona84 akatona84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but pls get approval from @guruchai

@guruchai
Copy link
Contributor

I had to dig around a bit to understand what exactly you are disabling. I am slightly confused with the changes.

  • The code to invalidate the cache in DefaultSchemaRegistry is already commented out. I dont see any calls inflow into HAServerNotificationManager.notify*. It looks the caching is already disabled.

What's the purpose of this change? Is it only avoid to db calls to fetch other instances info?

@raju-saravanan
Copy link
Collaborator Author

@guruchai : Caching was not disabled in MASTER. We raised a PR to disable it in CSP-3.0.0, with this change server side cache disabling is configuration from yaml.

@guruchai
Copy link
Contributor

lgtm..

@raju-saravanan raju-saravanan merged commit 3226c43 into hortonworks:master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akatona84 akatona84 akatona84 left review comments

@guruchai guruchai guruchai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow users to disable server side caching
3 participants
@raju-saravanan @guruchai @akatona84