MINOR : Refactor service principal configuration #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guruchai
reviewed
Mar 18, 2020
| @@ -94,23 +94,24 @@ public void run(RegistryConfiguration registryConfiguration, Environment environ | |||
| } | |||
|
|
|||
| private void initializeUGI(RegistryConfiguration conf) throws IOException { | |||
| LOG.debug("Initialization of User Group ininformation..."); | |||
| LOG.debug("Initialization of User Group information..."); | |||
| if (UserGroupInformation.isSecurityEnabled()) { | |||
There was a problem hiding this comment.
This check i believe requires core-site.xml. Can we not use the conf.getServiceAuthenticationConfiguration() itself?
| String keyTab = authMethodConf.getServerPrincipleKeytab(); | ||
| Map<String,String> serviceAuthenticationProperties = authMethodConf.getProperties(); | ||
| String principal = serviceAuthenticationProperties.get("principal"); | ||
| String keytab = serviceAuthenticationProperties.get("keytab"); |
There was a problem hiding this comment.
You should validate the principal and keytab for null and empty.
You should also catch exception from below, log it as error and then fallback to simple.
UserGroupInformation.loginUserFromKeytab(principal, keytab);
|
@guruchai: Addressed your review comments, can you have another look? |
guruchai
reviewed
Mar 20, 2020
| UserGroupInformation.loginUserFromKeytab(principal, keytab); | ||
| LOG.debug("Successfully logged in"); | ||
| } catch (Exception e) { | ||
| LOG.error("Failed to log in"); |
There was a problem hiding this comment.
Please log the exception.
|
Thanks @guruchai , addressed your comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.