MINOR: possibility to include mysql-connector jar in final tar.gz #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This functionality is tied to `with-mysql-jar` profile
akatona84
requested review from
kamalcph,
raju-saravanan,
guruchai and
in-park
|
@akatona84: May I know the motivation behind this ? |
Yes, it is required for cdp runtime. Libs dir won't be writeable by schemaregistry (otherwise bootstrap would download this jar) |
|
@akatona84: Alright. How will the oracle ojdbc dependencies be dealt with in CDP runtime? |
I think it wasn't provided in csp either. User will copy them in place. |
Change-Id: Id94973ec431846481a7cdee75e958ff0ac83d707
raju-saravanan
approved these changes
Feb 17, 2020
raju-saravanan
referenced
this pull request
in raju-saravanan/registry
Apr 21, 2020
… final tar.gz (#668)" This reverts commit 9e33b2b.
raju-saravanan
referenced
this pull request
in raju-saravanan/registry
Apr 21, 2020
… final tar.gz (#668)" This reverts commit 9e33b2b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality is tied to
with-mysql-jarprofile